]> git.karo-electronics.de Git - karo-tx-linux.git/commit
userns: Don't allow unprivileged creation of gid mappings
authorEric W. Biederman <ebiederm@xmission.com>
Sat, 6 Dec 2014 00:14:19 +0000 (18:14 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Jan 2015 18:00:50 +0000 (10:00 -0800)
commit804733ad85b1ab68812fa438b3b4133d1d85581a
tree5779fb0fcdc81dc9159d1b6295cd503a9ad2b1ba
parentf077e88fc9f0befcf0441be2fed9516881ab02ef
userns: Don't allow unprivileged creation of gid mappings

commit be7c6dba2332cef0677fbabb606e279ae76652c3 upstream.

As any gid mapping will allow and must allow for backwards
compatibility dropping groups don't allow any gid mappings to be
established without CAP_SETGID in the parent user namespace.

For a small class of applications this change breaks userspace
and removes useful functionality.  This small class of applications
includes tools/testing/selftests/mount/unprivilged-remount-test.c

Most of the removed functionality will be added back with the addition
of a one way knob to disable setgroups.  Once setgroups is disabled
setting the gid_map becomes as safe as setting the uid_map.

For more common applications that set the uid_map and the gid_map
with privilege this change will have no affect.

This is part of a fix for CVE-2014-8989.

Reviewed-by: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/user_namespace.c