]> git.karo-electronics.de Git - linux-beck.git/commit
powerpc: Convert cmp to cmpd in idle enter sequence
authorSegher Boessenkool <segher@kernel.crashing.org>
Thu, 6 Oct 2016 13:42:19 +0000 (13:42 +0000)
committerMichael Ellerman <mpe@ellerman.id.au>
Fri, 21 Oct 2016 21:44:38 +0000 (08:44 +1100)
commit80f23935cadb1c654e81951f5a8b7ceae0acc1b4
tree0f905e9fe97bab2935d11d67e57348ae78d50e32
parent62623d5f918fb1c8ed86b03b9a86cc81f1cb1878
powerpc: Convert cmp to cmpd in idle enter sequence

PowerPC's "cmp" instruction has four operands. Normally people write
"cmpw" or "cmpd" for the second cmp operand 0 or 1. But, frequently
people forget, and write "cmp" with just three operands.

With older binutils this is silently accepted as if this was "cmpw",
while often "cmpd" is wanted. With newer binutils GAS will complain
about this for 64-bit code. For 32-bit code it still silently assumes
"cmpw" is what is meant.

In this instance the code comes directly from ISA v2.07, including the
cmp, but cmpd is correct. Backport to stable so that new toolchains can
build old kernels.

Fixes: 948cf67c4726 ("powerpc: Add NAP mode support on Power7 in HV mode")
Cc: stable@vger.kernel.org # v3.0
Reviewed-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/include/asm/cpuidle.h