]> git.karo-electronics.de Git - linux-beck.git/commit
drbd: Fix a potential race that could case data inconsistency
authorLars Ellenberg <lars.ellenberg@linbit.com>
Mon, 26 Mar 2012 13:09:44 +0000 (15:09 +0200)
committerPhilipp Reisner <philipp.reisner@linbit.com>
Thu, 8 Nov 2012 15:58:17 +0000 (16:58 +0100)
commit81f448629aa25051c47b4d5b81702da8cbe922c3
treed2df79e1f6a7e442008bd69325e29bd80b06f116
parent38a05c16b8fc855db2294eec36fde2c665b14e8f
drbd: Fix a potential race that could case data inconsistency

When we have a write request and a state change C_WF_BITMAP_S -> C_SYNC_SOURCE
at the same time, and it happens that the line

    remote = remote && drbd_should_do_remote(s);

stills sees C_WF_BITMAP_S, and

     send_oos = rw == WRITE && drbd_should_send_oos(s);

already sees C_SYNC_SOURCE both are 0.

This causes the write to not be mirrored, but marked as out-of-sync on the
Sync_Source node.

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
drivers/block/drbd/drbd_req.c