]> git.karo-electronics.de Git - karo-tx-linux.git/commit
add forgotten ->b_data in memcpy() call in ext3/resize.c (oopsable)
authorAl Viro <viro@zeniv.linux.org.uk>
Wed, 29 Nov 2006 10:40:22 +0000 (11:40 +0100)
committerAdrian Bunk <bunk@stusta.de>
Wed, 29 Nov 2006 10:40:22 +0000 (11:40 +0100)
commit82182ed2ce8df69635bcfed4baad8bbfae842bc8
treeda5bc595a8151b82150069759097c6dc1d358d4d
parentcf76a4a8bd6b14d9fc09e2d050253dc70312c273
add forgotten ->b_data in memcpy() call in ext3/resize.c (oopsable)

sbi->s_group_desc is an array of pointers to buffer_head.  memcpy() of
buffer size from address of buffer_head is a bad idea - it will generate
junk in any case, may oops if buffer_head is close to the end of slab
page and next page is not mapped and isn't what was intended there.
IOW, ->b_data is missing in that call.  Fortunately, result doesn't go
into the primary on-disk data structures, so only backup ones get crap
written to them; that had allowed this bug to remain unnoticed until
now.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
fs/ext3/resize.c
include/linux/skbuff.h
net/ipv4/ip_output.c
net/ipv6/ip6_output.c