]> git.karo-electronics.de Git - linux-beck.git/commit
msm_serial_hs: Fix type inconsistency for tx and rx command_ptr_ptr
authorMayank Rana <mrana@codeaurora.org>
Thu, 8 Dec 2011 03:36:08 +0000 (09:06 +0530)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sat, 10 Dec 2011 03:10:04 +0000 (19:10 -0800)
commit8431de80dad20979cc8354a90f70e2faac017932
treee5b8357dd31a65405f3d9b4887a7b22724a1e988
parent7f97c000e87751fdca69d14cba2bbba795c1a972
msm_serial_hs: Fix type inconsistency for tx and rx command_ptr_ptr

Both tx and rx command_ptr_ptr are of type u32*. While allocating
memory for it, sizeof(u32 *) is used as part of kmalloc API instead
of sizeof(u32). ADM Hardare requires size of command_ptr_ptr as 1 Word.
Both sizeof(u32 *) and sizeof(u32) are same on 32-bit architecture
whereas sizeof(u32 *) would be different in size compare to sizeof(u32)
on anyother architecture.

Hence correct usage of sizeof(command_ptr_ptr) for Tx and Rx with
kmalloc and dma_(map/unmap)_single APIs.

Signed-off-by: Mayank Rana <mrana@codeaurora.org>
Reported-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/tty/serial/msm_serial_hs.c