]> git.karo-electronics.de Git - karo-tx-linux.git/commit
x86, hotplug: Serialize CPU hotplug to avoid bringup concurrency issues
authorBorislav Petkov <bp@amd64.org>
Thu, 19 Aug 2010 18:10:29 +0000 (20:10 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 26 Aug 2010 23:43:26 +0000 (16:43 -0700)
commit858ba8a4118f7b1cef6cc70d85ffbf5fbaf9ec78
tree912d6b2fd641daaa8afa031166e228c04ced3eb0
parenta1c9f6469110c9962b7e74acba2fe05741650501
x86, hotplug: Serialize CPU hotplug to avoid bringup concurrency issues

commit d7c53c9e822a4fefa13a0cae76f3190bfd0d5c11 upstream.

When testing cpu hotplug code on 32-bit we kept hitting the "CPU%d:
Stuck ??" message due to multiple cores concurrently accessing the
cpu_callin_mask, among others.

Since these codepaths are not protected from concurrent access due to
the fact that there's no sane reason for making an already complex
code unnecessarily more complex - we hit the issue only when insanely
switching cores off- and online - serialize hotplugging cores on the
sysfs level and be done with it.

[ v2.1: fix !HOTPLUG_CPU build ]

Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
LKML-Reference: <20100819181029.GC17171@aftab>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/x86/Kconfig
arch/x86/kernel/smpboot.c