]> git.karo-electronics.de Git - karo-tx-linux.git/commit
vmscan.c: fix invalid strict_strtoul() check in write_scan_unevictable_node()
authorKautuk Consul <consul.kautuk@gmail.com>
Wed, 28 Sep 2011 00:50:26 +0000 (10:50 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Thu, 29 Sep 2011 06:08:12 +0000 (16:08 +1000)
commit85db1e283d38f7b41d2c401af7d07ae3acad7763
treea792c7cbdca6798cd41385188258d1d1394921a8
parenteb59dec1358eaf874384ab1b504f6c9341e7ada4
vmscan.c: fix invalid strict_strtoul() check in write_scan_unevictable_node()

write_scan_unevictable_node() checks the value req returned by
strict_strtoul() and returns 1 if req is 0.

However, when strict_strtoul() returns 0, it means successful conversion
of buf to unsigned long.

Due to this, the function was not proceeding to scan the zones for
unevictable pages even though we write a valid value to the
scan_unevictable_pages sys file.

Change this check slightly to check for invalid value in buf as well as 0
value stored in res after successful conversion via strict_strtoul.  In
both cases, we do not perform the scanning of this node's zones.

Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Johannes Weiner <jweiner@redhat.com>
Cc: Lee Schermerhorn <lee.schermerhorn@hp.com>
Signed-off-by: Andrew Morton <>
mm/vmscan.c