]> git.karo-electronics.de Git - linux-beck.git/commit
perf diff: Fix -o/--order option behavior (again)
authorNamhyung Kim <namhyung@kernel.org>
Wed, 18 Jan 2017 05:14:57 +0000 (14:14 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Feb 2017 23:25:42 +0000 (15:25 -0800)
commit85df621b18e2f20731a1a6eb4defd8b704487064
tree22d5e2e843227a2444ff84322cc1d24390dd3f2c
parent6b4af0dab8934b046776a65fdd6e91658f500060
perf diff: Fix -o/--order option behavior (again)

commit a1c9f97f0b64e6337d9cfcc08c134450934fdd90 upstream.

Commit 21e6d8428664 ("perf diff: Use perf_hpp__register_sort_field
interface") changed list_add() to perf_hpp__register_sort_field().

This resulted in a behavior change since the field was added to the tail
instead of the head.  So the -o option is mostly ignored due to its
order in the list.

This patch fixes it by adding perf_hpp__prepend_sort_field().

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Fixes: 21e6d8428664 ("perf diff: Use perf_hpp__register_sort_field interface")
Link: http://lkml.kernel.org/r/20170118051457.30946-2-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/perf/builtin-diff.c
tools/perf/ui/hist.c
tools/perf/util/hist.h