]> git.karo-electronics.de Git - karo-tx-linux.git/commit
can: c_can: precedence error in c_can_chip_config()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 15 Jun 2012 00:20:44 +0000 (00:20 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 4 Jul 2012 04:44:19 +0000 (05:44 +0100)
commit86f65876182c72dfae0f7d1ecd619f6fc39b1ff0
tree0d42d38c4c3ec51258c130e35830bc6f50493ec2
parentbc623ac31d51f12113e40085f08fbccf585220bd
can: c_can: precedence error in c_can_chip_config()

commit d9cb9bd63eb27ac19f26a8547128c053f43a5da8 upstream.

(CAN_CTRLMODE_LISTENONLY & CAN_CTRLMODE_LOOPBACK) is (0x02 & 0x01) which
is zero so the condition is never true.  The intent here was to test
that both flags were set.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/can/c_can/c_can.c