]> git.karo-electronics.de Git - linux-beck.git/commit
bnx2x: Prevent restarting Tx during bnx2x_nic_unload
authorVladislav Zolotarov <vladz@broadcom.com>
Tue, 2 Aug 2011 08:35:43 +0000 (01:35 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 2 Aug 2011 08:35:43 +0000 (01:35 -0700)
commit87b7ba3d24a25cf18aece447de27d7804fa9668c
tree3d47489b40ee858ddc093069a8723c2d9a63fcf8
parent22019b17821ab3543090827491e465c5816cbcd6
bnx2x: Prevent restarting Tx during bnx2x_nic_unload

Tx queues were stopped before  bp->state was changed to a value different
from BNX2X_STATE_OPEN, which allowed the bnx2x_tx_int() called from the
NAPI context to re-enable it. This then allowed the netdev->ndo_start_xmit()
to be called in the middle of the function reset and rings freeing.

This patch changes bp->state to a value different
from BNX2X_STATE_OPEN BEFORE disabling the Tx queues in order to restore the
broken protection against the above race in the bnx2x_tx_int().

Signed-off-by: Vladislav Zolotarov <vladz@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bnx2x/bnx2x_cmn.c