]> git.karo-electronics.de Git - mv-sheeva.git/commit
ASoC: pl022_ds.c: Add of_node_put to avoid memory leak
authorJulia Lawall <julia@diku.dk>
Tue, 31 Aug 2010 15:48:56 +0000 (17:48 +0200)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Thu, 2 Sep 2010 15:28:49 +0000 (16:28 +0100)
commit880b8ffd45bf46f783b8b0d009487d89fd37b608
tree225085f161842344c3152838db6cbd28af035334
parent3ba31051f1bbdad3c6b597903f7a2ee3b00e001e
ASoC: pl022_ds.c: Add of_node_put to avoid memory leak

Add a call to of_node_put in the error handling code following a call to
of_parse_phandle.

This patch also moves the existing call to of_node_put tothe end of the
error handling code, to make it possible to jump to of_node_put without
doing the other cleanup operations.  These appear to be disjoint
operations, so the ordering doesn't matter.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
local idexpression x;
expression E,E1,E2;
statement S;
@@

*x =
(of_find_node_by_path
|of_find_node_by_name
|of_find_node_by_phandle
|of_get_parent
|of_get_next_parent
|of_get_next_child
|of_find_compatible_node
|of_match_node
|of_find_node_by_type
|of_find_node_with_property
|of_find_matching_node
|of_parse_phandle
)(...);
...
if (x == NULL) S
<... when != x = E
*if (...) {
  ... when != of_node_put(x)
      when != if (...) { ... of_node_put(x); ... }
(
  return <+...x...+>;
|
*  return ...;
)
}
...>
(
E2 = x;
|
of_node_put(x);
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Timur Tabi <timur@freescale.com>
Acked-by: Liam Girdwood <lrg@slimlogic.uo.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
sound/soc/fsl/p1022_ds.c