]> git.karo-electronics.de Git - karo-tx-linux.git/commit
rbd: be picky about osd request status type
authorAlex Elder <elder@dreamhost.com>
Thu, 8 Nov 2012 14:01:39 +0000 (08:01 -0600)
committerAlex Elder <elder@inktank.com>
Thu, 17 Jan 2013 20:53:20 +0000 (14:53 -0600)
commit8986cb37b1cf1f54b35f062f0a12dc68dd89f311
tree597989d74b68bb1f11743dcd5cc5d9e597664fb8
parent5f29ddd4f0954ad6c84e28b934773f128840f064
rbd: be picky about osd request status type

The result field in a ceph osd reply header is a signed 32-bit type,
but rbd code often casually uses int to represent it.

The following changes the types of variables that handle this result
value to be "s32" instead of "int" to be completely explicit about
it.  Only at the point we pass that result to __blk_end_request()
does the type get converted to the plain old int defined for that
interface.

There is almost certainly no binary impact of this change, but I
prefer to show the exact size and signedness of the value since we
know it.

Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Dan Mick <dan.mick@inktank.com>
drivers/block/rbd.c