]> git.karo-electronics.de Git - karo-tx-linux.git/commit
md/raid1: don't abort a resync on the first badblock.
authorNeilBrown <neilb@suse.de>
Tue, 31 Jul 2012 00:05:34 +0000 (10:05 +1000)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 9 Aug 2012 23:25:00 +0000 (00:25 +0100)
commit898ece8e5e5102c627f8f2ef26d281f71b439169
tree0dbc3ba9d11e198d2cc88006ede55ffcca1d7805
parent1c88c581bfe3afd2d21a14b6dee7011af8512f91
md/raid1: don't abort a resync on the first badblock.

commit b7219ccb33aa0df9949a60c68b5e9f712615e56f upstream.

If a resync of a RAID1 array with 2 devices finds a known bad block
one device it will neither read from, or write to, that device for
this block offset.
So there will be one read_target (The other device) and zero write
targets.
This condition causes md/raid1 to abort the resync assuming that it
has finished - without known bad blocks this would be true.

When there are no write targets because of the presence of bad blocks
we should only skip over the area covered by the bad block.
RAID10 already gets this right, raid1 doesn't.  Or didn't.

As this can cause a 'sync' to abort early and appear to have succeeded
it could lead to some data corruption, so it suitable for -stable.

Reported-by: Alexander Lyakas <alex.bolshoy@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/md/raid1.c