]> git.karo-electronics.de Git - linux-beck.git/commit
x86/efi: Fix multiple GOP device support
authorKővágó, Zoltán <dirty.ice.hu@gmail.com>
Mon, 12 Oct 2015 14:13:56 +0000 (15:13 +0100)
committerIngo Molnar <mingo@kernel.org>
Wed, 14 Oct 2015 14:02:43 +0000 (16:02 +0200)
commit8a53554e12e98d1759205afd7b8e9e2ea0936f48
tree5bb1ac598ad41587735943b993784f13884afbcf
parent5b5f1455272e23f4e7889cec37228802d8d01adf
x86/efi: Fix multiple GOP device support

When multiple GOP devices exists, but none of them implements
ConOut, the code should just choose the first GOP (according to
the comments). But currently 'fb_base' will refer to the last GOP,
while other parameters to the first GOP, which will likely
result in a garbled display.

I can reliably reproduce this bug using my ASRock Z87M Extreme4
motherboard with CSM and integrated GPU disabled, and two PCIe
video cards (NVidia GT640 and GTX980), booting from efi-stub
(booting from grub works fine).  On the primary display the
ASRock logo remains and on the secondary screen it is garbled
up completely.

Signed-off-by: Kővágó, Zoltán <DirtY.iCE.hu@gmail.com>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Cc: <stable@vger.kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1444659236-24837-2-git-send-email-matt@codeblueprint.co.uk
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/boot/compressed/eboot.c