]> git.karo-electronics.de Git - linux-beck.git/commit
[media] media: vb2: Take queue or device lock in mmap-related vb2 ioctl handlers
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Fri, 2 Aug 2013 16:55:21 +0000 (13:55 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Sun, 18 Aug 2013 10:22:07 +0000 (07:22 -0300)
commit8a90f1a61c9b31bd0c89b8456fa4dce91ad69c57
tree04e4cb64f0f3213d2e0102ad7a7be4546c781090
parent5548a382508f1f76320e1ed55524dda73234299d
[media] media: vb2: Take queue or device lock in mmap-related vb2 ioctl handlers

The vb2_fop_mmap() and vb2_fop_get_unmapped_area() functions are plug-in
implementation of the mmap() and get_unmapped_area() file operations
that calls vb2_mmap() and vb2_get_unmapped_area() on the queue
associated with the video device. Neither the
vb2_fop_mmap/vb2_fop_get_unmapped_area nor the
v4l2_mmap/vb2_get_unmapped_area functions in the V4L2 core take any
lock, leading to race conditions between mmap/get_unmapped_area and
other buffer-related ioctls such as VIDIOC_REQBUFS.
Fix it by taking the queue or device lock around the vb2_mmap() and
vb2_get_unmapped_area() calls.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/v4l2-core/videobuf2-core.c