]> git.karo-electronics.de Git - karo-tx-linux.git/commit
drm/i915: Hold mode_config->mutex during hotplug processing
authorKeith Packard <keithp@keithp.com>
Mon, 25 Jul 2011 17:04:56 +0000 (10:04 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 16 Aug 2011 01:31:35 +0000 (18:31 -0700)
commit8b01249b9fe0697eb66e8d0bf41a714d91d039ce
tree751403dcf6ee23da953ed2d8ca10da671fc18137
parent3f6846490d30a4b6e127bc522615db58721a8cdc
drm/i915: Hold mode_config->mutex during hotplug processing

commit a65e34c79c88895766ab1f8a5afa451eed26622b upstream.

Hotplug detection is a mode setting operation and must hold the
struct_mutex or risk colliding with other mode setting operations.

In particular, the display port hotplug function attempts to re-train
the link if the monitor is supposed to be running when plugged back
in. If that happens while mode setting is underway, the link will get
scrambled, leaving it in an inconsistent state.

This is a special case -- usually the driver mode setting entry points
are covered by the upper level DRM code, but in this case the function
is invoked as a work function not under the control of DRM.

Signed-off-by: Keith Packard <keithp@keithp.com>
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/gpu/drm/i915/i915_irq.c