]> git.karo-electronics.de Git - karo-tx-linux.git/commit
slub: fix panic with DISCONTIGMEM
authorJames Bottomley <James.Bottomley@HansenPartnership.com>
Tue, 19 Apr 2011 21:29:36 +0000 (16:29 -0500)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 9 May 2011 22:54:51 +0000 (15:54 -0700)
commit8ba5e329539971614c5e4438f48ffb23414b67a3
treeee07f1f6abb1dc499eec18dde390042b017ace85
parent548a4a8c2bffd5748f88aff92cea844a842535b8
slub: fix panic with DISCONTIGMEM

commit 4a5fa3590f09999f6db41bc386bce40848fa9f63 upstream.

Slub makes assumptions about page_to_nid() which are violated by
DISCONTIGMEM and !NUMA.  This violation results in a panic because
page_to_nid() can be non-zero for pages in the discontiguous ranges and
this leads to a null return by get_node().  The assertion by the
maintainer is that DISCONTIGMEM should only be allowed when NUMA is also
defined.  However, at least six architectures: alpha, ia64, m32r, m68k,
mips, parisc violate this.  The panic is a regression against slab, so
just mark slub broken in the problem configuration to prevent users
reporting these panics.

Acked-by: David Rientjes <rientjes@google.com>
Acked-by: Pekka Enberg <penberg@kernel.org>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
init/Kconfig