]> git.karo-electronics.de Git - karo-tx-linux.git/commit
net: nb8800: avoid uninitialized variable warning
authorArnd Bergmann <arnd@arndb.de>
Fri, 29 Jan 2016 11:39:14 +0000 (12:39 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 30 Jan 2016 04:33:39 +0000 (20:33 -0800)
commit8bdb290896d2ff22942c9c9f5bf19909329f3664
tree6e29b42ed69a5248d89a33a54844c7c25b16cd8b
parent57e7c8cef224af166b8ec932b5e383641418c005
net: nb8800: avoid uninitialized variable warning

The nb8800_poll() function initializes the 'next' variable in the
loop looking for new input data. We know this will be called at
least once because 'budget' is a guaranteed to be a positive number
when we enter the function, but the compiler doesn't know that
and warns when the variable is used later:

drivers/net/ethernet/aurora/nb8800.c: In function 'nb8800_poll':
drivers/net/ethernet/aurora/nb8800.c:350:21: warning: 'next' may be used uninitialized in this function [-Wmaybe-uninitialized]

Changing the 'while() {}' loop to 'do {} while()' makes it obvious
to the compiler what is going on so it no longer warns.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Mans Rullgard <mans@mansr.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/aurora/nb8800.c