]> git.karo-electronics.de Git - linux-beck.git/commit
serial: sh-sci: fix common SCIFB regmap definition
authorTakashi Yoshii <takashi.yoshii.zj@renesas.com>
Fri, 16 Nov 2012 01:53:31 +0000 (10:53 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 16 Nov 2012 02:02:51 +0000 (18:02 -0800)
commit8c66d6d2a1a572768616ddca2c3863384b14d846
tree03009efbd0a88bd5a44bd1d6e90b03a0d8ccdc77
parent63f7ad115ef35b711f3ae2b46a07acbf1ca3bdfd
serial: sh-sci: fix common SCIFB regmap definition

About FIFO count, there are two variants of SCIFs which show
a) TX count in upper, RX count in lower byte of FDR register
b) TX count in TFDR register, RX count in RFDR register

Common SCIFB regmap in current source code is defined as "a".
At least 7372 and 73a0 HW manual say their SICFB are "b".

This patch alters the definition to "b", considering the current
one has come from a mistake. The reason is as follows.

The flag SCIFB sh-sci driver means it has 256 byte FIFO.
The count is from 0(empty) to 256(full), that makes 9-bit.
Because FDR is 16-bit register, it can not hold two 9-bits.
That's why, SCIFB can not be "a".

Signed-off-by: Takashi Yoshii <takashi.yoshii.zj@renesas.com>
Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sh-sci.c