]> git.karo-electronics.de Git - karo-tx-linux.git/commit
[media] go7007: dubious one-bit signed bitfields
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 17 Apr 2013 06:20:30 +0000 (03:20 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 22 Apr 2013 13:10:20 +0000 (10:10 -0300)
commit8c93c40080bda655295ae3673dfb26dee34d9d49
treedadf1fde95e496b71eecbfab88a0c7508cf37cb6
parent5ddfbbb9ca2e74d4b392ccef675641babba6b7f8
[media] go7007: dubious one-bit signed bitfields

Because they're signed, "is_video" and "is_audio" can be 0 and -1
instead of 0 and 1 as intended.  It doesn't cause a bug, but it makes
Sparse complain:
drivers/staging/media/go7007/go7007-priv.h:94:31: error: dubious one-bit signed bitfield
drivers/staging/media/go7007/go7007-priv.h:95:31: error: dubious one-bit signed bitfield

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/staging/media/go7007/go7007-priv.h