]> git.karo-electronics.de Git - linux-beck.git/commit
packet: fix packet_direct_xmit for BQL enabled drivers
authorDaniel Borkmann <dborkman@redhat.com>
Wed, 2 Apr 2014 18:52:57 +0000 (20:52 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 3 Apr 2014 18:29:12 +0000 (14:29 -0400)
commit8e2f1a63f2217365223026422a2f8ba5967051d6
tree617c58bd5a55d41cfe3c28e1087a17691f1ae197
parent0f97ede45e65ffb6eab856313e79b14b902bcfaa
packet: fix packet_direct_xmit for BQL enabled drivers

Currently, in packet_direct_xmit() we test the assigned netdevice queue
for netif_xmit_frozen_or_stopped() before doing an ndo_start_xmit().

This can have the side-effect that BQL enabled drivers which make use
of netdev_tx_sent_queue() internally, set __QUEUE_STATE_STACK_XOFF from
within the stack and would not fully fill the device's TX ring from
packet sockets with PACKET_QDISC_BYPASS enabled.

Instead, use a test without BQL bit so that bursts can be absorbed
into the NICs TX ring. Fix and code suggested by Eric Dumazet, thanks!

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/netdevice.h
net/packet/af_packet.c