]> git.karo-electronics.de Git - karo-tx-linux.git/commit
hugetlb: detect race upon page allocation failure during COW
authorHillf Danton <dhillf@gmail.com>
Fri, 2 Dec 2011 03:11:59 +0000 (14:11 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Tue, 6 Dec 2011 03:59:23 +0000 (14:59 +1100)
commit8e30d069d313c5cb3896159ecd4d5dcb5c10fdbf
tree8515dbd58a2a58707dad1389e599ca0aceca2938
parent791f6921179f34995858516086c33e34eebb2900
hugetlb: detect race upon page allocation failure during COW

Currently we are not rechecking pte_same in hugetlb_cow after we take ptl
lock again in the page allocation failure code path and simply retry
again.  This is not an issue at the moment because hugetlb fault path is
protected by hugetlb_instantiation_mutex so we cannot race.

The original page is locked and so we cannot race even with the page
migration.

Let's add the pte_same check anyway as we want to be consistent with the
other check later in this function and be safe if we ever remove the
mutex.

[mhocko@suse.cz: reworded the changelog]
Signed-off-by: Hillf Danton <dhillf@gmail.com>
Signed-off-by: Michal Hocko <mhocko@suse.cz>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Johannes Weiner <jweiner@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/hugetlb.c