]> git.karo-electronics.de Git - karo-tx-linux.git/commit
p54: fix tx feedback status flag check
authorChristian Lamparter <chunkeey@googlemail.com>
Tue, 24 Aug 2010 20:54:05 +0000 (22:54 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 20 Sep 2010 20:17:55 +0000 (13:17 -0700)
commit8fdd6243c34ea97465f10be83384f7c9cafb17f5
treee87b61d296bba9e7c01967a1735e9841236ea27f
parenta4bc94d437129f5c5fe64b1f58691a6e8d113e74
p54: fix tx feedback status flag check

commit f880c2050f30b23c9b6f80028c09f76e693bf309 upstream.

Michael reported that p54* never really entered power
save mode, even tough it was enabled.

It turned out that upon a power save mode change the
firmware will set a special flag onto the last outgoing
frame tx status (which in this case is almost always the
designated PSM nullfunc frame). This flag confused the
driver; It erroneously reported transmission failures
to the stack, which then generated the next nullfunc.
and so on...

Reported-by: Michael Buesch <mb@bu3sch.de>
Tested-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/wireless/p54/txrx.c