]> git.karo-electronics.de Git - karo-tx-linux.git/commit
mmc_spi: fail gracefully if host or card do not support the switch command
authorWolfgang Muees <wolfgang.mues@auerswald.de>
Tue, 22 Sep 2009 23:45:26 +0000 (16:45 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 5 Oct 2009 16:31:38 +0000 (09:31 -0700)
commit904f470bbf1cb422b963bc3d479930e0968c30ed
tree23ac8db7488eeb33bb3ba9c62ca2a10b3ed59acb
parentb01436041fc2be04f5dbbbfdc5a37643cd9417b4
mmc_spi: fail gracefully if host or card do not support the switch command

commit d08ebeddfb3293fa4bdfca9c610daf1e8ec8b233 upstream.

Some time ago, I have send a patch to the mmc_spi subsystem changing the
error codes.  This was after a discussion with Pierre about using EINVAL
only for non-recoverable errors.  This patch was accepted as

http://git.kernel.org/linus/fdd858db7113ca64132de390188d7ca00701013d

Unfortunately, several weeks later, I realized that this patch has opened
a little can of worms because there are SD cards on the market which

a) claim that they support the switch command
AND
b) refuse to execute this command if operating in SPI mode.

So, such a card would get unusuable in an embedded linux system in SPI
mode, because the init sequence terminates with an error.

This patch adds the missing error codes to the caller of the switch
command and restores the old behaviour to fail gracefully if these
commands can not execute.

Signed-off-by: Wolfgang Muees <wolfgang.mues@auerswald.de>
Cc: <linux-mmc@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/mmc/core/mmc.c
drivers/mmc/core/sd.c