]> git.karo-electronics.de Git - karo-tx-linux.git/commit
coredump: change wait_for_dump_helpers() to use wait_event_interruptible()
authorOleg Nesterov <oleg@redhat.com>
Wed, 20 Mar 2013 04:08:31 +0000 (15:08 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Thu, 21 Mar 2013 05:34:29 +0000 (16:34 +1100)
commit9295d5f5d807834a600f1e303a9ddcccb0002b1e
tree5f43f717238c672729f93c04045a7beb44ab7386
parent336676ed109b64fad22c7488ddf4800ecee7f4b4
coredump: change wait_for_dump_helpers() to use wait_event_interruptible()

wait_for_dump_helpers() calls wake_up/kill_fasync from inside the
wait_event-like loop.  This is not needed and in fact this is not strictly
correct, we can/should do this only once after we change pipe->writers.
We could even check if it becomes zero.

Change this code to use use wait_event_interruptible(), this can also help
to make this wait freezable.

With this patch we check pipe->readers without pipe_lock(), this is fine.
Once we see pipe->readers == 1 we know that the handler decremented the
counter, this is all we need.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Mandeep Singh Baines <msb@chromium.org>
Cc: Neil Horman <nhorman@redhat.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/coredump.c