]> git.karo-electronics.de Git - linux-beck.git/commit
ath9k: fix moredata flag endianness in cabq tx
authorMichal Kazior <michal.kazior@tieto.com>
Thu, 9 Jul 2015 10:27:22 +0000 (12:27 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 21 Jul 2015 15:01:35 +0000 (18:01 +0300)
commit92cd40322848a12f1f3ef2d7804233b93030c532
tree5fc8a73846b471994657a78ae311fdfc7c6f19d6
parent77661208a87b458f353fd0b7a4729cf2887449a6
ath9k: fix moredata flag endianness in cabq tx

While compiling ath9k with some extra flags I've
found that:

 ath9k/xmit.c +2473 ## 16: warning: restricted __le16 degrades to integer
 ath9k/xmit.c +2474 ## 36: warning: invalid assignment: &=
 ath9k/xmit.c +2474 ## 36:    left side has type restricted __le16
 ath9k/xmit.c +2474 ## 36:    right side has type int

There's no way for frame ftype/stype to be
mistreated as the offending 'moredata' flag when
considering cab queue.

This could've however theoretically led sometimes
to increased power consumption on connected
stations as they would keep their Rx active
waiting for frames that would never come.

Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/ath9k/xmit.c