]> git.karo-electronics.de Git - karo-tx-linux.git/commit
can bcm: fix tx_setup off-by-one errors
authorOliver Hartkopp <socketcan@hartkopp.net>
Fri, 23 Sep 2011 08:23:47 +0000 (08:23 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 11 Nov 2011 17:36:25 +0000 (09:36 -0800)
commit92dc979cf8a5b2439ac2764cd56675407136d329
treebc1171d65440a30eddc8aeef5ffff0bedea3f986
parent99dfac8ab234555a54f7fa6e4b7bb08bb355158b
can bcm: fix tx_setup off-by-one errors

[ Upstream commit aabdcb0b553b9c9547b1a506b34d55a764745870 ]

This patch fixes two off-by-one errors that canceled each other out.
Checking for the same condition two times in bcm_tx_timeout_tsklet() reduced
the count of frames to be sent by one. This did not show up the first time
tx_setup is invoked as an additional frame is sent due to TX_ANNONCE.
Invoking a second tx_setup on the same item led to a reduced (by 1) number of
sent frames.

Reported-by: Andre Naujoks <nautsch@gmail.com>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/can/bcm.c