]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ocfs2_connection_find() returns pointer to bad structure
authordann frazier <dann.frazier@canonical.com>
Thu, 18 Nov 2010 22:03:09 +0000 (15:03 -0700)
committerWilly Tarreau <w@1wt.eu>
Sat, 30 Apr 2011 14:53:02 +0000 (16:53 +0200)
commit95dbe336d30e9356c20fc37f6351a0d0c17ad790
treeae9f980d986058ee9419ec265f2473c6f6453a79
parentaadbd20969785c1d15a84d151fed0aa2a8873732
ocfs2_connection_find() returns pointer to bad structure

commit 226291aa4641fa13cb5dec3bcb3379faa83009e2 upstream.

If ocfs2_live_connection_list is empty, ocfs2_connection_find() will return
a pointer to the LIST_HEAD, cast as a ocfs2_live_connection. This can cause
an oops when ocfs2_control_send_down() dereferences c->oc_conn:

Call Trace:
  [<ffffffffa00c2a3c>] ocfs2_control_message+0x28c/0x2b0 [ocfs2_stack_user]
  [<ffffffffa00c2a95>] ocfs2_control_write+0x35/0xb0 [ocfs2_stack_user]
  [<ffffffff81143a88>] vfs_write+0xb8/0x1a0
  [<ffffffff8155cc13>] ? do_page_fault+0x153/0x3b0
  [<ffffffff811442f1>] sys_write+0x51/0x80
  [<ffffffff810121b2>] system_call_fastpath+0x16/0x1b

Fix by explicitly returning NULL if no match is found.

Signed-off-by: dann frazier <dann.frazier@canonical.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/ocfs2/stack_user.c