]> git.karo-electronics.de Git - karo-tx-linux.git/commit
pci: revert SMBus unhide on HP Compaq nx6110
authorJean Delvare <khali@linux-fr.org>
Fri, 28 Mar 2008 21:16:04 +0000 (14:16 -0700)
committerChris Wright <chrisw@sous-sol.org>
Sat, 19 Apr 2008 01:53:21 +0000 (18:53 -0700)
commit96c132f39fc8514e2bd2d56b95442879c56308fe
treec48e91bfe7b0862b687bee1a0354adce24b9707d
parent6ed609bc70e1cce983650707b0b7c12265ab96f6
pci: revert SMBus unhide on HP Compaq nx6110

upstream commit: a99acc832de1104afaba02d7c2576fd9b9fd6422

This reverts commit 3c0a654e390d00fef9d8faed758f5e1e8078adb5 and
fixes kernel bug #10245:

http://bugzilla.kernel.org/show_bug.cgi?id=10245

The HP Compaq nc6120 has the same PCI sub-device ID as the nx6110, and the
SMBus is used by ACPI for thermal management on the nc6120, so Linux should
not attach a native driver to it.  This means that this quirk is unsafe and
has to be removed.

I also added a comment to help developers realize that adding new IDs to this
SMBus unhiding quirk table should be done only with great care, and in
particular only after checking that ACPI is not making use of the SMBus.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Tomasz Koprowski <tomek@koprowski.org>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
drivers/pci/quirks.c