]> git.karo-electronics.de Git - karo-tx-linux.git/commit
wmi: use memcmp instead of strncmp to compare GUIDs
authorThadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Sun, 28 Nov 2010 21:46:50 +0000 (19:46 -0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 21 Mar 2011 19:44:14 +0000 (12:44 -0700)
commit971a8db01d3de4f15e6aff74012b2e68387700e3
treee6db769e984b33df52dca86c4260cadab1e5be30
parentc72eb4d4a0239d8940b027bbe0ce3cd9a66d4635
wmi: use memcmp instead of strncmp to compare GUIDs

commit 8b14d7b22c61f17ccb869e0047d9df6dd9f50a9f upstream.

While looking for the duplicates in /sys/class/wmi/, I couldn't find
them. The code that looks for duplicates uses strncmp in a binary GUID,
which may contain zero bytes. The right function is memcmp, which is
also used in another section of wmi code.

It was finding 49142400-C6A3-40FA-BADB-8A2652834100 as a duplicate of
39142400-C6A3-40FA-BADB-8A2652834100. Since the first byte is the fourth
printed, they were found as equal by strncmp.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/platform/x86/wmi.c