]> git.karo-electronics.de Git - karo-tx-linux.git/commit
arch/x86/kernel: Add missing spin_unlock
authorJulia Lawall <julia@diku.dk>
Thu, 27 May 2010 10:31:51 +0000 (12:31 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 5 Jul 2010 18:15:59 +0000 (11:15 -0700)
commit974c45b17ec9837a2eee7d37a42be250ad5b5086
tree5da95dda13cad554fdac497d061b9ac7f22d7edc
parent1f55cdf626c7a0aaa20bba6832352fef6fb1127e
arch/x86/kernel: Add missing spin_unlock

commit 84fe6c19e4a598e8071e3bd1b2c923454eae1268 upstream.

Add a spin_unlock missing on the error path.  The locks and unlocks are
balanced in other functions, so it seems that the same should be the case
here.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression E1;
@@

* spin_lock(E1,...);
  <+... when != E1
  if (...) {
    ... when != E1
*   return ...;
  }
  ...+>
* spin_unlock(E1,...);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/x86/kernel/amd_iommu.c