]> git.karo-electronics.de Git - karo-tx-linux.git/commit
[media] pwc: Remove a bunch of bogus sanity checks / don't return EFAULT wrongly
authorHans de Goede <hdegoede@redhat.com>
Mon, 6 Jun 2011 18:25:18 +0000 (15:25 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 7 Jul 2011 21:26:37 +0000 (18:26 -0300)
commit9750cdda957446720dd71d3828e77a08f044f8df
treea1b6de3bed623c44e1bd8d0abd393474e39dff38
parent775d4038b79f1371af3ed9cfe5ab8592af1b30e2
[media] pwc: Remove a bunch of bogus sanity checks / don't return EFAULT wrongly

The chances if any of these becoming NULL magically are 0% And if they
do become NULL oopsing is the right thing to do (so that the user logs a
bug with the kernel rather then with whatever app he was using).

Returning EFAULT to userspace should only be done when userspace supplies
a bad address, not on driver bugs / hw issues, so in the few cases where the
check is not bogus return something else.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/pwc/pwc-if.c
drivers/media/video/pwc/pwc-uncompress.c
drivers/media/video/pwc/pwc-v4l.c