]> git.karo-electronics.de Git - karo-tx-linux.git/commit
[SCSI] st: fix race in st_scsi_execute_end
authorPetr Uzel <petr.uzel@suse.cz>
Fri, 21 Oct 2011 11:31:09 +0000 (13:31 +0200)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Fri, 17 Aug 2012 19:35:50 +0000 (15:35 -0400)
commit97547b895b4485f7097ceefbbfd42806c8c03496
tree2e984184c3f649cfd7c8b3f66cc359fb2178b1de
parentd3f610aeedcdfda9967c612b52be2b2815f76156
[SCSI] st: fix race in st_scsi_execute_end

commit c68bf8eeaa57c852e74adcf597237be149eef830 upstream.

The call to complete() in st_scsi_execute_end() wakes up sleeping thread
in write_behind_check(), which frees the st_request, thus invalidating
the pointer to the associated bio structure, which is then passed to the
blk_rq_unmap_user(). Fix by storing pointer to bio structure into
temporary local variable.

This bug is present since at least linux-2.6.32.

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Reported-by: Juergen Groß <juergen.gross@ts.fujitsu.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Acked-by: Kai Mäkisara <kai.makisara@kolumbus.fi>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
drivers/scsi/st.c