]> git.karo-electronics.de Git - karo-tx-linux.git/commit
genirq: Avoid deadlock in spurious handling
authorThomas Gleixner <tglx@linutronix.de>
Fri, 23 Nov 2012 09:08:44 +0000 (10:08 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 6 Mar 2013 03:22:34 +0000 (03:22 +0000)
commit9771304decd27e25593b1c3f6cd80a91c1c8f219
tree83f8a6c3d43f1b3f6d8c181bbec054d70d9f73f6
parent3208ee7f73115f8a92912ad05a15b97da41fae58
genirq: Avoid deadlock in spurious handling

commit e716efde75267eab919cdb2bef5b2cb77f305326 upstream.

commit 52553ddf(genirq: fix regression in irqfixup, irqpoll)
introduced a potential deadlock by calling the action handler with the
irq descriptor lock held.

Remove the call and let the handling code run even for an interrupt
where only a single action is registered. That matches the goal of
the above commit and avoids the deadlock.

Document the confusing action = desc->action reload in the handling
loop while at it.

Reported-and-tested-by: "Wang, Warner" <warner.wang@hp.com>
Tested-by: Edward Donovan <edward.donovan@numble.net>
Cc: "Wang, Song-Bo (Stoney)" <song-bo.wang@hp.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
kernel/irq/spurious.c