]> git.karo-electronics.de Git - karo-tx-linux.git/commit
oprofile: don't call arch exit code from init code on failure
authorWill Deacon <will.deacon@arm.com>
Sun, 29 Aug 2010 18:51:59 +0000 (14:51 -0400)
committerRobert Richter <robert.richter@amd.com>
Tue, 31 Aug 2010 09:47:50 +0000 (11:47 +0200)
commit979048e1f26190d16b5aea87166177f37e614439
tree28c6e5c6c11343f934249cfdf9cc806f8a587758
parent2bfc96a127bc1cc94d26bfaa40159966064f9c8c
oprofile: don't call arch exit code from init code on failure

oprofile_init calls oprofile_arch_init to initialise the architecture-specific
backend code. If this backend code returns failure, oprofile_arch_exit is
called immediately, making it difficult to allocate and free resources
correctly.

This patch removes the oprofile_arch_exit call from oprofile_init,
meaning that all architectures must ensure that oprofile_arch_init
cleans up any mess it's made before returning an error. As far as
I can tell, this only affects the code for ARM.

Cc: Robert Richter <robert.richter@amd.com>
Cc: Matt Fleming <matt@console-pimps.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Robert Richter <robert.richter@amd.com>
drivers/oprofile/oprof.c