]> git.karo-electronics.de Git - karo-tx-linux.git/commit
sched: fix hrtick_start_fair and CPU-Hotplug
authorPeter Zijlstra <peterz@infradead.org>
Tue, 6 May 2008 03:05:15 +0000 (03:05 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sat, 10 May 2008 04:40:44 +0000 (21:40 -0700)
commit980e8ec0c4ab54164725f1a71545c439a755e918
tree8a81b1527f730bbfe1aa907875ca32ef81cfe445
parentf9dfda1ad0637a89a64d001cf81478bd8d9b6306
sched: fix hrtick_start_fair and CPU-Hotplug

commit: b328ca182f01c2a04b85e0ee8a410720b104fbcc upstream

Gautham R Shenoy reported:

 > While running the usual CPU-Hotplug stress tests on linux-2.6.25,
 > I noticed the following in the console logs.
 >
 > This is a wee bit difficult to reproduce. In the past 10 runs I hit this
 > only once.
 >
 > ------------[ cut here ]------------
 >
 > WARNING: at kernel/sched.c:962 hrtick+0x2e/0x65()
 >
 > Just wondering if we are doing a good job at handling the cancellation
 > of any per-cpu scheduler timers during CPU-Hotplug.

This looks like its indeed not cancelled at all and migrates the it to
another cpu. Fix it via a proper hotplug notifier mechanism.

Reported-by: Gautham R Shenoy <ego@in.ibm.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
kernel/sched.c