]> git.karo-electronics.de Git - mv-sheeva.git/commit
wimax/i2400m: fix race condition with tcpdump et al
authorInaky Perez-Gonzalez <inaky@linux.intel.com>
Tue, 29 Sep 2009 23:28:24 +0000 (16:28 -0700)
committerInaky Perez-Gonzalez <inaky@linux.intel.com>
Mon, 19 Oct 2009 06:56:12 +0000 (15:56 +0900)
commit9835fd84990ca253c5b625005717a9be492788c0
tree9daa36006886eecf80fe5c715049ef8307aecc0a
parente1633fd636f3ed0379fcf08c47962205eadddb6b
wimax/i2400m: fix race condition with tcpdump et al

tcpdump and friends were not being able to decode packets sent via
WiMAX; they had a zero ethernet type, even when the stack was properly
sending them to the device with the right type.

It happens that the driver was overwriting the (fake) ethernet header
for creating the hardware header and that was bitting the cloning used
by tcpdump (et al) to look into the packets.

Use pkskb_expand_head() [method copied from the e1000 driver] to fix.

Thanks to Herbert Xu and Andi Kleen for helping to diagnose and
pointing to the right fix.

Cc: Herbert Xu <gondor.apana.org.au>
Cc: Andi Kleen <andi@firstfloor.org>
Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
drivers/net/wimax/i2400m/netdev.c