]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ASoC: Intel: sst: Delete sst_shim_regs64; saved regs are never used
authorDouglas Anderson <dianders@chromium.org>
Tue, 30 May 2017 16:51:30 +0000 (09:51 -0700)
committerMark Brown <broonie@kernel.org>
Tue, 6 Jun 2017 18:58:49 +0000 (19:58 +0100)
commit98cf2c03b467fa67df58cb52adeb85b425cabcb2
treeece5ab998581df5dc6d08c606a3e35d8f1edf082
parent0809d9871d1066634f8abae9ecfbdfadecb8cd35
ASoC: Intel: sst: Delete sst_shim_regs64; saved regs are never used

In commit 9a075265c6dc ("ASoC: Intel: sst: Remove unused function
sst_restore_shim64()"), we deleted the sst_restore_shim64() since it
was never used.  ...but a quick look at the code shows that we should
also be able to remove the sst_save_shim64() function and the
structure members we were storing data in.

Once we delete sst_save_shim64() there are no longer any users of the
'sst_shim_regs64' structure.  That means we can delete it completely
and also avoid allocating memory for it.  This saves a whopping 136
bytes of devm allocated memory.  We also get the nice benefit of
avoiding an error path in the init code.

Note that the saving code that we're removing (and the comments
talking about how important it is to do the save) has been around
since commit 336cfbb05edf ("ASoC: Intel: mrfld- add ACPI module").

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/atom/sst/sst.c
sound/soc/intel/atom/sst/sst.h
sound/soc/intel/atom/sst/sst_acpi.c