]> git.karo-electronics.de Git - karo-tx-linux.git/commit
jbd: Fix forever sleeping process in do_get_write_access()
authorJan Kara <jack@suse.cz>
Thu, 5 May 2011 11:59:35 +0000 (13:59 +0200)
committerAndi Kleen <ak@linux.intel.com>
Mon, 1 Aug 2011 20:54:50 +0000 (13:54 -0700)
commit9907f140638ef8492c3ecd35db8d2f6b28f5c781
tree44fbf8a0aa56408c026df0be63b2c4e11b83f44d
parent94f69b03006a2119db2e7f1f6db453fe58e530b8
jbd: Fix forever sleeping process in do_get_write_access()

commit 2842bb20eed2e25cde5114298edc62c8883a1d9a upstream.

In do_get_write_access() we wait on BH_Unshadow bit for buffer to get
from shadow state. The waking code in journal_commit_transaction() has
a bug because it does not issue a memory barrier after the buffer is moved
from the shadow state and before wake_up_bit() is called. Thus a waitqueue
check can happen before the buffer is actually moved from the shadow state
and waiting process may never be woken. Fix the problem by issuing proper
barrier.

Reported-by: Tao Ma <boyu.mt@taobao.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
fs/jbd/commit.c