]> git.karo-electronics.de Git - karo-tx-linux.git/commit
drm/i915: Kill dangerous pending-flip debugging
authorChris Wilson <chris@chris-wilson.co.uk>
Sat, 15 May 2010 08:57:03 +0000 (09:57 +0100)
committerEric Anholt <eric@anholt.net>
Wed, 26 May 2010 21:11:45 +0000 (14:11 -0700)
commit9908ff736adf261e749b4887486a32ffa209304c
treeac2aceb5f2d598f5bbd112cbe0553edc51a9b124
parentf1befe71fa7a79ab733011b045639d8d809924ad
drm/i915: Kill dangerous pending-flip debugging

We can, by virtue of a vblank interrupt firing in the middle of setting
up the unpin work (i.e. after we set the unpin_work field and before we
write to the ringbuffer) enter intel_finish_page_flip() prior to
receiving the pending flip notification. Therefore we can expect to hit
intel_finish_page_flip() under normal circumstances without a pending flip
and even without installing the pending_flip_obj. This is exacerbated by
aperture thrashing whilst binding the framebuffer

References:

  Bug 28079 - "glresize" causes kernel panic in intel_finish_page_flip.
  https://bugs.freedesktop.org/show_bug.cgi?id=28079

Reported-by: Nick Bowler <nbowler@draconx.ca>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: stable@kernel.org
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Eric Anholt <eric@anholt.net>
drivers/gpu/drm/i915/intel_display.c