]> git.karo-electronics.de Git - linux-beck.git/commit
drbd: fix thread stop deadlock
authorLars Ellenberg <lars.ellenberg@linbit.com>
Mon, 2 May 2011 09:47:18 +0000 (11:47 +0200)
committerPhilipp Reisner <philipp.reisner@linbit.com>
Thu, 8 Nov 2012 15:53:00 +0000 (16:53 +0100)
commit992d6e91d3654c11c2e4d8d5933ffbf82a0440f0
treeb97d1371d9a0a93d539174ecdd8cfe205b56cf43
parentf3dfa40a67c354a5886c5ae53a9c5d3a2c6fd06e
drbd: fix thread stop deadlock

There are races where the receiver may be exiting,
but still need the worker to process some stuff.

Do not wait for the receiver to die from an exiting worker.
The receiver must already be dead in case the worker decides to exit.
If the receiver was still alive, it may still want to queue work, and do
drbd_flush_workqueue() from it's disconnect cleanup code,
which would no longer be processed by an exiting worker.

This also would deadlock,
if the worker was to synchornously wait for the receiver to die.

Do not implicitly stop the worker.
The worker will only be stopped from configuration context, from
conn_reconfig_done(), drbd_adm_down() or drbd_adm_delete_connection(),
after making sure the receiver is already stopped.

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
drivers/block/drbd/drbd_main.c
drivers/block/drbd/drbd_nl.c
drivers/block/drbd/drbd_state.c
drivers/block/drbd/drbd_worker.c