]> git.karo-electronics.de Git - karo-tx-linux.git/commit
r8169: fix random mdio_write failures
authorTimo Teräs <timo.teras@iki.fi>
Sun, 6 Jun 2010 22:38:47 +0000 (15:38 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 27 Sep 2010 00:21:21 +0000 (17:21 -0700)
commit9ab48c2ea9806947d8f5fcadb0c47767c29f175c
treed360821697ed4c065ae7b073cb03ca73bae90f29
parent0987a43dadd8a45843c906d674221b180488e42d
r8169: fix random mdio_write failures

[ Upstream commit 024a07bacf8287a6ddfa83e9d5b951c5e8b4070e ]

Some configurations need delay between the "write completed" indication
and new write to work reliably.

Realtek driver seems to use longer delay when polling the "write complete"
bit, so it waits long enough between writes with high probability (but
could probably break too). This patch adds a new udelay to make sure we
wait unconditionally some time after the write complete indication.

This caused a regression with XID 18000000 boards when the board specific
phy configuration writing many mdio registers was added in commit
2e955856ff (r8169: phy init for the 8169scd). Some of the configration
mdio writes would almost always fail, and depending on failure might leave
the PHY in non-working state.

Signed-off-by: Timo Teräs <timo.teras@iki.fi>
Acked-off-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/r8169.c