]> git.karo-electronics.de Git - karo-tx-linux.git/commit
cifs: fix possible memory corruption in CIFSFindNext
authorJeff Layton <jlayton@redhat.com>
Tue, 23 Aug 2011 11:21:28 +0000 (07:21 -0400)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Fri, 17 Aug 2012 19:35:01 +0000 (15:35 -0400)
commit9b8bef04268052450e00719b178f1879048a32b5
tree7310a643817451b901a90ea3a73ae968ae1f75cb
parenta1fca431f3ae6019da1896bb2ed384dbe9b08ca4
cifs: fix possible memory corruption in CIFSFindNext

commit 9438fabb73eb48055b58b89fc51e0bc4db22fabd upstream.

The name_len variable in CIFSFindNext is a signed int that gets set to
the resume_name_len in the cifs_search_info. The resume_name_len however
is unsigned and for some infolevels is populated directly from a 32 bit
value sent by the server.

If the server sends a very large value for this, then that value could
look negative when converted to a signed int. That would make that
value pass the PATH_MAX check later in CIFSFindNext. The name_len would
then be used as a length value for a memcpy. It would then be treated
as unsigned again, and the memcpy scribbles over a ton of memory.

Fix this by making the name_len an unsigned value in CIFSFindNext.

Reported-by: Darren Lavender <dcl@hppine99.gbr.hp.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
fs/cifs/cifssmb.c