]> git.karo-electronics.de Git - karo-tx-linux.git/commit
cifs: fix the format specifiers in sid_to_str
authorJeff Layton <jlayton@redhat.com>
Fri, 19 Oct 2012 15:23:58 +0000 (11:23 -0400)
committerJeff Layton <jlayton@redhat.com>
Fri, 19 Oct 2012 15:23:58 +0000 (11:23 -0400)
commit9b9fac56d43f386cb40e63dc62a528a717cd68eb
treeeea81c1f34473f63c7540172998bad0cdaf9cd04
parenta0aa9d61684941566a679eef2f082bf881c60c4b
cifs: fix the format specifiers in sid_to_str

The format specifiers are for signed values, but these are unsigned.
Given that '-' is a delimiter between fields, I don't think you'd get
what you'd expect if you got a value here that would overflow the sign
bit.

The version and authority fields are 8 bit values so use a "hh" length
modifier there. The subauths are 32 bit values, so there's no need to
use a "l" length modifier there.

Reviewed-by: Shirish Pargaonkar <shirishpargaonkar@gmail.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
fs/cifs/cifsacl.c