]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ocfs2: avoid unaligned access to dqc_bitmap
authorAkinobu Mita <akinobu.mita@gmail.com>
Wed, 5 Oct 2011 00:42:35 +0000 (11:42 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Wed, 12 Oct 2011 06:31:54 +0000 (17:31 +1100)
commit9bbfe04b0f9f32f74a491f3ebc75c2609bbaa8dc
tree1517a2a8857f78c6d914d00022f9d467fa2b2e7d
parent0a1254393647336ab980bd79e3b7cb7f07444621
ocfs2: avoid unaligned access to dqc_bitmap

The dqc_bitmap field of struct ocfs2_local_disk_chunk is 32-bit aligned,
but not 64-bit aligned.  The dqc_bitmap is accessed by ocfs2_set_bit(),
ocfs2_clear_bit(), ocfs2_test_bit(), or ocfs2_find_next_zero_bit().  These
are wrapper macros for ext2_*_bit() which need to take an unsigned long
aligned address (though some architectures are able to handle unaligned
address correctly)

So some 64bit architectures may not be able to access the dqc_bitmap
correctly.

This avoids such unaligned access by using another wrapper functions for
ext2_*_bit().  The code is taken from fs/ext4/mballoc.c which also need to
handle unaligned bitmap access.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Acked-by: Joel Becker <jlbec@evilplan.org>
Cc: Mark Fasheh <mfasheh@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/ocfs2/ocfs2.h
fs/ocfs2/quota_local.c