]> git.karo-electronics.de Git - karo-tx-linux.git/commit
netfilter: ipt_CLUSTERIP: fix buffer overflow
authorVasiliy Kulikov <segoon@openwall.com>
Sun, 20 Mar 2011 14:42:52 +0000 (15:42 +0100)
committerAndi Kleen <ak@linux.intel.com>
Thu, 28 Apr 2011 15:20:57 +0000 (08:20 -0700)
commit9c09bd6e205093f8344028671260efd1687f26b9
tree33653036a6728384625e2f98f43cd466d5b22a07
parentd52f8b882ab7a4c44dc04b7195266c75e236b4f0
netfilter: ipt_CLUSTERIP: fix buffer overflow

commit 961ed183a9fd080cf306c659b8736007e44065a5 upstream.

'buffer' string is copied from userspace.  It is not checked whether it is
zero terminated.  This may lead to overflow inside of simple_strtoul().
Changli Gao suggested to copy not more than user supplied 'size' bytes.

It was introduced before the git epoch.  Files "ipt_CLUSTERIP/*" are
root writable only by default, however, on some setups permissions might be
relaxed to e.g. network admin user.

Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Acked-by: Changli Gao <xiaosuo@gmail.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
net/ipv4/netfilter/ipt_CLUSTERIP.c