]> git.karo-electronics.de Git - karo-tx-linux.git/commit
staging: unisys: visornic: prevent hang doing 'modprobe -r visornic'
authorTim Sell <Timothy.Sell@unisys.com>
Wed, 1 Feb 2017 22:38:58 +0000 (17:38 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Feb 2017 12:10:49 +0000 (13:10 +0100)
commit9c70ee32ffedc48705b08d97212683a5482628cb
tree6593e7603381eaaf7a80e6e3d17aaeef5857366a
parent7289a8dd2b258d267e5405f656d7f27c82fba014
staging: unisys: visornic: prevent hang doing 'modprobe -r visornic'

A stray+extraneous 'netif_napi_add()' that we were doing in
visornic_probe() was causing havoc when we got into visornic_remove(),
called during 'modprobe -r visornic'. The symptom was a processor busy-wait
loop on the modprobe process, which '/proc/<pid>/stack' would show looping
doing napi things.

Presumably the stray line got there as a result of some merging snafoo, and
has been deleted to fix the problem. With this patch 'modprobe -r visornic'
and a subsequent 'modprobe visornic' both complete successfully, and result
in an operational network.

Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visornic/visornic_main.c