]> git.karo-electronics.de Git - karo-tx-linux.git/commit
mpt2sas: fix the incorrect scsi_dma_map error checking
authorFUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Tue, 9 Mar 2010 02:09:50 +0000 (11:09 +0900)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Wed, 14 Mar 2012 14:57:51 +0000 (10:57 -0400)
commit9d30e342aba315aa777d00a5c681179de24a0f04
tree51fa10ba5b1e5cc2cacca76a1f0db304a859557d
parentda3a3ee57bc3af9c5c89b62cf79c2117b22a5597
mpt2sas: fix the incorrect scsi_dma_map error checking

commit bb789d01620e5d36081b22edb6fb71cf55ff043c upstream.

scsi_dma_map() returns -1 if an error occurred (zero means that the
command has no data). So the following current code can't catch an
error:

sges_left = scsi_dma_map(scmd);
if (!sges_left) {
sdev_printk(KERN_ERR, scmd->device, "pci_map_sg"
" failed: request for %d bytes!\n", scsi_bufflen(scmd));
return -ENOMEM;
}

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Acked-by: "Desai, Kashyap" <Kashyap.Desai@lsi.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
drivers/scsi/mpt2sas/mpt2sas_scsih.c