]> git.karo-electronics.de Git - karo-tx-linux.git/commit
fs: remove incorrect I_NEW warnings
authorNick Piggin <npiggin@suse.de>
Tue, 2 Jun 2009 10:07:47 +0000 (12:07 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 2 Jul 2009 23:49:31 +0000 (16:49 -0700)
commit9d3d447703cec0582ff5a5756aeb07e4593f9cb6
treed3fa4a531826cb058e5ad6c0e184bc8819801686
parent7cceae83c14ed46837366e27ff7979af48130188
fs: remove incorrect I_NEW warnings

commit 545b9fd3d737afc0bb5203b1e79194a471605acd upstream.

Some filesystems can call in to sync an inode that is still in the
I_NEW state (eg. ext family, when mounted with -osync). This is OK
because the filesystem has sole access to the new inode, so it can
modify i_state without races (because no other thread should be
modifying it, by definition of I_NEW). Ie. a false positive, so
remove the warnings.

The races are described here 7ef0d7377cb287e08f3ae94cebc919448e1f5dff,
which is also where the warnings were introduced.

Reported-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/fs-writeback.c