]> git.karo-electronics.de Git - karo-tx-linux.git/commit
x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted
authorPaolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Thu, 15 Feb 2007 02:34:23 +0000 (03:34 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 9 Mar 2007 18:50:17 +0000 (10:50 -0800)
commit9d4b636cfc1e76ec86d6ef5c7a100195c7c12d23
treed96b0e72b7dd9abfcb9b37091ce92dfe295b5c2f
parent89417b1a154b1963d739c56585a45df42a9a9107
x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted

Also PTRACE_OLDSETOPTIONS should be accepted, as done by kernel/ptrace.c and
forced by binary compatibility. UML/32bit breaks because of this - since it is wise
enough to use PTRACE_OLDSETOPTIONS to be binary compatible with 2.4 host
kernels.

Until 2.6.17 (commit f0f2d6536e3515b5b1b7ae97dc8f176860c8c2ce) we had:

       default:
                return sys_ptrace(request, pid, addr, data);

Instead here we have:
        case PTRACE_GET_THREAD_AREA:
case ...:
                return sys_ptrace(request, pid, addr, data);

        default:
                return -EINVAL;

This change was a style change - when a case is added, it must be explicitly
tested this way. In this case, not enough testing was done.

Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/x86_64/ia32/ptrace32.c